[SSSD] [INI] Assorted patches for ding-libs

Dmitri Pal dpal at redhat.com
Fri Jul 20 20:36:57 UTC 2012


Hello,

Here is a bunch of patches for review:

Patch 1:
 The unit test was not correct. The paths to files used in the unit test
were wrong. It used function exec instead of system which is bad too.
 It was hard to see what is going on so some more verbose output added.
 The config files are now copied our of the ini.d directory. The
permission test is adjusted.

Patch 2:
Can be squashed into previous one but I decided against it as it is a
change in configure.am not in code.
Patch 1 does all the copying of the files used in the unit test so there
is no need to copy file at the configure stage.

Patch 3:
Couple convenience functions for the value object that turned out to be
missing

Patches 4-10 (big!!!):
Definition, implementation, unit tests and docs for the new INI
interface that uses value object instead of the bare strings.
There is a lot of code there but it is mostly inspired by existing
interface. It exists in parallel for the backward compatibility.
Old inteface is still built, just not advertised via the docs. It needs
couple more layers of polish before it can be called complete.
The new interface is mostly a copy of the old interface so no big
logical differences other than ability to have keys with multiple values
in the same file.
For example there is now a way to deal with case like this:

file=x1
file=x2
file=x3

and get all the values for key "file" one at a time.



Plans for the near future:
1) Finish the section merge - it is not complete but when it is this
interface will be completely functional. The goal to that during August.
2) Provide a patch for SSSD to switch to the new interface - for August too.
This is the moment when we can call it v1.

Longer term plans:
1) Add functions to create config file to the interface. Currently it is
a the processing/parsing part, but you can't easily construct the
configuration file, only read it.
2) Add validation as it was originally planned.

I will try to find the victim to do the long term changes as I do not
scale for this any more.

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-INI-Fix-permission-checking-unit-test.patch
Type: text/x-patch
Size: 17321 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-INI-The-implementation-of-the-new-interface.patch
Type: text/x-patch
Size: 39150 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-INI-Unit-test-for-the-new-interface.patch
Type: text/x-patch
Size: 33249 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-INI-Add-a-search-state-to-the-config-object.patch
Type: text/x-patch
Size: 2912 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-INI-Definition-of-the-new-INI-interface.patch
Type: text/x-patch
Size: 54122 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-INI-Adding-cople-functions-to-value-object.patch
Type: text/x-patch
Size: 3783 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-INI-No-need-to-copy-file-in-configure-any-more.patch
Type: text/x-patch
Size: 860 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-INI-Start-building-the-new-interface.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-INI-Added-new-tests-for-the-multi-value-keys.patch
Type: text/x-patch
Size: 844 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-INI-Build-docs-for-new-interface.patch
Type: text/x-patch
Size: 973 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120720/b3dd3c0f/attachment-0009.bin>


More information about the sssd-devel mailing list