[SSSD] [PATCH] resolv_gethostbyname_send: talloc_strdup hostname on state

Pavel Březina pbrezina at redhat.com
Mon Jul 16 14:19:24 UTC 2012


On 07/16/2012 04:15 PM, Stephen Gallagher wrote:
> On Mon, 2012-07-16 at 16:10 +0200, Pavel Březina wrote:
>> On 07/16/2012 04:00 PM, Stephen Gallagher wrote:
>>> On Mon, 2012-07-16 at 15:59 +0200, Pavel Březina wrote:
>>>> If we provide a hostname that was allocated on stack, it may contain
>>>> invalid data in the time when it is actually resolved.
>>>
>>> Nack.
>>>
>>> Please test for NULL after talloc_strdup() in the case of ENOMEM.
>>
>> Oops, right. New patch is attached.
>> Thanks.
>
> Nack. Please keep the allocation and check together.

New patch attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-resolv_gethostbyname_send-strdup-hostname-to-work-pr.patch
Type: text/x-patch
Size: 1973 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120716/82ccd0d2/attachment.bin>


More information about the sssd-devel mailing list