[SSSD] [PATCH] Print pointer contents not address

Stephen Gallagher sgallagh at redhat.com
Mon Jul 9 11:28:12 UTC 2012


On Sun, 2012-07-08 at 22:02 +0200, Jakub Hrozek wrote:
> I was not able to log in today, I was getting krb5_child segfaults. The
> attached patch fixed that.

Nack.

I fail to see how this could possibly have caused a segfault. The
previous version would have been printing either "true" or "false" based
on whether the pointer was NULL or contained a value. This was
incorrect, but should be impossible to segfault on.

However, the new patch changes this to a dereference without checking
the validity of the offline pointer first. So now you've introduced the
possibility of a segfault if the pointer is uninitialized (though it
never should be).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120709/09fa74d6/attachment.sig>


More information about the sssd-devel mailing list