[SSSD] [PATCH] SUDO: Provide documentation for the SUDO API

Stephen Gallagher sgallagh at redhat.com
Tue Jan 31 02:48:07 UTC 2012


On Mon, 2012-01-30 at 21:47 -0500, Stephen Gallagher wrote:
> On Mon, 2012-01-30 at 16:24 +0100, Jakub Hrozek wrote:
> > On Sat, Jan 28, 2012 at 05:05:03PM +0100, Jakub Hrozek wrote:
> > > On Mon, Jan 23, 2012 at 10:34:42AM -0500, Stephen Gallagher wrote:
> > > > On Mon, 2012-01-23 at 16:29 +0100, Jakub Hrozek wrote:
> > > > > On Sun, Jan 22, 2012 at 07:32:28PM -0500, Stephen Gallagher wrote:
> > > > > > On Sun, 2012-01-22 at 20:34 +0100, Jakub Hrozek wrote:
> > > > > > > On Sat, Jan 21, 2012 at 05:12:49PM -0500, Stephen Gallagher wrote:
> > > > > > > > On Thu, 2012-01-19 at 13:51 +0100, Jakub Hrozek wrote:
> > > > > > > > > [PATCH 1/2] HBAC docs: Fix path to libipa_hbac header file
> > > > > > > > > I noticed the HBAC docs directory contained just a stub index.html
> > > > > > > > > 
> > > > > > > > > [PATCH 2/2] SUDO: Provide documentation for the SUDO API
> > > > > > > > > The API should be documented in order to be easily consumable by the
> > > > > > > > > SUDO project
> > > > > > > > 
> > > > > > > > Nack.
> > > > > > > > I applied these two patches, ran configure and then 'make && make docs'
> > > > > > > > and only got a stub index.html for both of them.
> > > > > > > > 
> > > > > > > > Note: I build in a parallel build directory. It's possible that this is
> > > > > > > > where the disconnect is occurring.
> > > > > > > 
> > > > > > > You're right, I only tested in-tree build. I think I don't quite understand
> > > > > > > how autoconf substitutions work for srcdir subdirectories.
> > > > > > > 
> > > > > > > If I build in-tree, then @srcdir@ is substituted for "." which is what
> > > > > > > I'd expect.
> > > > > > > 
> > > > > > > However, when I build in a parallel dir and run:
> > > > > > > $ /path/to/sssd/configure $options
> > > > > > > then the relative path inside sssd tree is appended to
> > > > > > > /path/to/sssd and @srcdir@ expands to /path/to/sssd/src/providers/ipa/
> > > > > > > in ipa_hbac.doxy. This seems confusing, I would still expect only
> > > > > > > /path/to/sssd/.
> > > > > > 
> > > > > > Yeah, that's quite strange. @srcdir@ *is* supposed to be /path/to/sssd
> > > > > > there. Could be an autoconf bug :(
> > > > > 
> > > > > My autoconf-fu is not that strong but Sumit directed me to @top_srcdir@
> > > > > and @abs_top_srcdir@ which seem to work fine.
> > > > > 
> > > > > New patches attached.
> > > > 
> > > > Please test these on RHEL 5. I seem to recall that abs_top_srcdir isn't
> > > > available there. (I think we had to hack around that in some other parts
> > > > of the build environment, either in SSSD or ding-libs).
> > > 
> > > abs_top_srcdir was introduced to autoconf in 2.57, RHEL-5 contains 2.59.
> > > The substitution works fine.
> > > 
> > > We don't build the documentation on RHEL5, though (c.f.
> > > e2986bbe269ce93fc4a60f57e962fb9e2ebbddac).
> > > 
> > > I realized I forgot to fix the file src/doxy.config.in, though. New
> > > patches are attached.
> > > 
> > > The sudo documentation has also been updated to reflect the recent
> > > changes.
> > 
> > Self-nack. Those patches moved a member of a structure which would be an
> > ABI break.
> > 
> > New patches attached.
> 
> Ack to these patches.
> 
> Something they made me notice was that we're returning something called
> sss_result to the SUDO provider. I think that's too generically named
> and really needs to be changed to sss_sudo_result. I've opened
> https://fedorahosted.org/sssd/ticket/1159 to track this.

Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120130/478a2227/attachment.sig>


More information about the sssd-devel mailing list