[SSSD] [PATCH] Free internal account request when finished

Stephen Gallagher sgallagh at redhat.com
Sat Jan 21 17:19:10 UTC 2012


On Fri, 2012-01-20 at 11:28 -0500, Simo Sorce wrote:
> On Fri, 2012-01-20 at 16:20 +0100, Jakub Hrozek wrote:
> > 
> > I noticed that we never marked the internal account request as done so
> > the internal _recv function was never called and we would never free
> > the
> > internal tevent_req structure. That means the responder_ctx would grow
> > in size..
> > 
> > The attached patch marks the internal request as done when all the
> > callbacks are handled. The outside account_done function is then only
> > called for the request that triggered DP lookup and the internal
> > request
> > is freed.
> > 
> 
> Jakub,
> I and Stephen discussed the patch a bit.
> 
> I'd like to NACK for the following reasons, that are not your fault, but
> require addressing IMO.
> 
> To fix the real issue ASAP I would prefer a minimal patch that simply
> adds the talloc_free(subreq); and does not touch the other code.
> 
> The reason to NACK is that the original code is a bit too confusing, it
> should be refactored a bit to change naming as it wrongly uses the
> naming convention in an unconventional situation.
> 
> The new patch would also need quite a bit of comments because otherwise
> following what is going on is arduous.
> 
> If you want to take up the task of proposing both a minimilastic first
> step patch and a more complete one that would be nice, but not strictly
> necessary. If you do not have the time please open a new ticket for the
> second part, and just do the minimum necessary to fix the leak and
> nothing more.



While working on the services map patches, I discovered what I believe
to be the real issues behind this. I'm sending them as a new patch in
the thread "[PATCH] DP: Fix bugs in sss_dp_get_account_int"

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120121/c1ba085a/attachment.sig>


More information about the sssd-devel mailing list