[SSSD] [PATCH] Do not use sudo symbols in LDAP provider unconditionally

Sumit Bose sbose at redhat.com
Wed Jan 18 10:14:40 UTC 2012


On Wed, Jan 18, 2012 at 10:19:52AM +0100, Jakub Hrozek wrote:
> Unbreaks the LDAP provider.

I hope the following haven't been discussed before for sudo.

Just a general comment and maybe this is already planned for the sudo
integration. We tried to avoid ifdef's in the main part of the code and
placed platform/version/feature specific functionality in separate
files, see e.g. src/util/sss_ldap.c, src/util/sss_krb5.c or
src/providers/ldap/sdap_fd_events.c. If possible I think it would make
sense to move sdap_sudo_setup_tasks() to sdap_sudo.c and try to move
other code in #ifdef BUILD_SUDO-#endif there as well.

bye,
Sumit

> From 62d2f143d4a802beaddde097c6b6c04af02d9731 Mon Sep 17 00:00:00 2001
> From: Jakub Hrozek <jhrozek at redhat.com>
> Date: Wed, 18 Jan 2012 10:16:44 +0100
> Subject: [PATCH] Do not use sudo symbols in LDAP provider unconditionally
> 
> ---
>  src/providers/ldap/ldap_common.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
> index 18df5ba86588297af8be5bc5d38b5b3700d11749..ba94d549cb74559de16b1a8bcb904c938fa35e37 100644
> --- a/src/providers/ldap/ldap_common.c
> +++ b/src/providers/ldap/ldap_common.c
> @@ -567,6 +567,7 @@ int ldap_get_sudo_options(TALLOC_CTX *memctx,
>      return EOK;
>  }
>  
> +#ifdef BUILD_SUDO
>  int sdap_sudo_setup_tasks(struct sdap_id_ctx *id_ctx)
>  {
>      struct sdap_sudo_refresh_ctx *refresh_ctx = NULL;
> @@ -623,6 +624,7 @@ int sdap_sudo_setup_tasks(struct sdap_id_ctx *id_ctx)
>  
>      return EOK;
>  }
> +#endif
>  
>  errno_t sdap_parse_search_base(TALLOC_CTX *mem_ctx,
>                                 struct dp_option *opts, int class,
> -- 
> 1.7.7.4
> 

> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel




More information about the sssd-devel mailing list