[SSSD] [PATCHES] LDAP: Copy URI instead of pointing at failover service record

Stephen Gallagher sgallagh at redhat.com
Sat Jan 14 17:01:50 UTC 2012


On Fri, 2012-01-13 at 14:48 +0100, Jakub Hrozek wrote:
> On Thu, Jan 12, 2012 at 02:34:15PM -0500, Stephen Gallagher wrote:
> > On Thu, 2012-01-12 at 20:24 +0100, Jakub Hrozek wrote:
> > > On Thu, Jan 12, 2012 at 01:51:54PM -0500, Stephen Gallagher wrote:
> > > > In a heavy load environment, sometimes the failover service record
> > > > would be updated and free the URI value. We need to guarantee that
> > > > this URI string remains valid throughout the entire request.
> > > > 
> > > > https://fedorahosted.org/sssd/ticket/1139
> > > > 
> > > > Patch 0001 adds and corrects some useful debugging information I used to
> > > > track down this issue.
> > > > 
> > > 
> > > Ack
> > > 
> > > > Patch 0002 implements the copying to guarantee the integrity of the
> > > > string until the request completes.
> > > 
> > > Does not seem to apply on top of origin/master. Do I need some other
> > > patch?
> > > 
> > > ++<<<<<<< HEAD
> > > +    timeout = dp_opt_get_int(state->opts->basic, SDAP_NETWORK_TIMEOUT);
> > > +
> > > +    subreq = sss_ldap_init_send(state, ev, uri, sockaddr,
> > > +                                sizeof(struct sockaddr_storage),
> > > +                                timeout);
> > > ++=======
> > > +     subreq = sss_ldap_init_send(state, ev, state->uri, sockaddr,
> > > +                                 sizeof(struct sockaddr_storage));
> > > ++>>>>>>> LDAP: Copy URI instead of pointing at failover service record
> > 
> > 
> > Ah, sorry. These were constructed on sssd-1-5.
> > 
> > Patches for master attached.
> 
> Ack to both.


Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120114/78321c5f/attachment.sig>


More information about the sssd-devel mailing list