[SSSD] [PATCHES] Couple enhancements of HBAC code

Jan Zelený jzeleny at redhat.com
Fri Jan 13 10:25:47 UTC 2012


> Dne 13.1.2012 09:58, Jan Zelený napsal(a):
> > Hi,
> > I'm sending two patches with enhancements related to IPA HBAC code. I
> > stumbled upon these while doing the SELinux work because I'm planning to
> > re-use some parts of the HBAC code.
> > 
> > #081:
> > Comment ipa_host_search_base in man pages - nothing special about this
> > one
> 
> NACK
> 
> Please, document the behaviour of dereference lookup when filter is set
> in search base.

Done

> 
> > #082:
> > Add support for multiple host search bases in HBAC code. I recall we
> > discussed this one several weeks ago and the conclusion was that we
> > wanted the support but it wasn't the number one topic at that moment.
> > 
> > The only limitation in my implementation is related to multiple search
> > bases in combination with dereference code. Basically, if
> > ipa_support_srchost = false and there is a filter given in host search
> > base, I ignore it. I believe something similar is already in other parts
> > of SSSD using deref. Correct me if I'm wrong.
> 
> NACK, just minor issues.
> 
> ipa_hbac_hosts.c:168
> ipa_hbac_hosts.c:310
> Instead of building state->cur_filter by your own you should use
> sdap_get_id_specific_filter().

I knew there was some kind of function for that. Thanks for pointing that out.

> ipa_hbac_hosts.c:380
> I suppose there should be 'Now' instead of 'No'

Actually no, the comment is correct.

> ipa_hbac_hosts.c:187
> Please, use new debug level macro.

That's what happens when I use copy & paste ;-)

New set of patches is in attachment.

Thanks
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-081-1-man-ipa_host_search_base.patch
Type: text/x-patch
Size: 2541 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120113/0c64cf59/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-082-1-hbac-multiple-host-search-bases.patch
Type: text/x-patch
Size: 15893 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120113/0c64cf59/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120113/0c64cf59/attachment.sig>


More information about the sssd-devel mailing list