[SSSD] [PATCHES] Improve group handling in the PAC responder

Simo Sorce simo at redhat.com
Wed Dec 19 13:10:02 UTC 2012


On Tue, 2012-12-18 at 21:43 +0100, Sumit Bose wrote:
> 
> I started to change it but didn't like the resulting code, because it
> turned out to be complex and hard to follow. Since the original struct
> only user 8 or 12 bytes per group (depending if your are on 32bits or
> on
> 64bits) I would prefer to keep the old struct for this round of
> patches.
> 
Sorry can't agree, space is only one of the factors, although completely
unnecessarily using 2x or 3x number of groups space is ugly enough,
But the main issues are really in the code this structure
allows/produces.

Still a nack for me.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list