[SSSD] [PATCH] Fix pam responder handling of coalesced requests

Jakub Hrozek jhrozek at redhat.com
Fri Dec 14 16:29:17 UTC 2012


On Fri, Dec 14, 2012 at 10:43:42AM +0100, Jakub Hrozek wrote:
> On Thu, Dec 13, 2012 at 11:25:25PM -0500, Simo Sorce wrote:
> > In our responders we have a feature that allows to avoid dispatching
> > multiple identical requests at the same time.
> > This is done by queing additional identical requests in a special hash
> > table and then replying to all clients at the same time when a response
> > is received.
> > 
> > When the connection to a provider breaks all these waiting requests need
> > to be cleaned out and the has table emptied.
> > 
> > This was not happening in sssd_pam, so if a connection to the provider
> > was lost client request would pile up and never be replied again.
> > 
> > The attached patch fixes this issue. Tested using kill -STOP of the
> > sssd_be process and trying to authenticate via the gnome screensaver.
> > 
> > Fixes: https://fedorahosted.org/sssd/ticket/1655
> > 
> > -- 
> > Simo Sorce * Red Hat, Inc * New York
> 
> Ack. Nice catch, thank you. The other *_dp_reconnect_init functions are
> fine.

Pushed to master and sssd-1-9



More information about the sssd-devel mailing list