[SSSD] [PATCH 0/4] [REBASE-2] Create and use an auth token object

Pavel Březina pbrezina at redhat.com
Mon Dec 3 14:34:43 UTC 2012


On 12/02/2012 05:59 AM, Simo Sorce wrote:
> Rebased again as requested by Pavel
>
> Simo Sorce (4):
>    Code can only check for cached passwords
>    Add function to safely wipe memory.
>    Add authtok utility functions.
>    Change pam data auth tokens.
>
>   Makefile.am                                        |    4 +
>   src/db/sysdb.h                                     |    3 +-
>   src/db/sysdb_ops.c                                 |   13 +--
>   src/providers/data_provider.h                      |    9 +-
>   src/providers/dp_auth_util.c                       |   76 +++++---
>   src/providers/dp_pam_data_util.c                   |  113 ++++++------
>   src/providers/ipa/ipa_auth.c                       |    6 +-
>   src/providers/krb5/krb5_auth.c                     |   52 +++---
>   src/providers/krb5/krb5_child.c                    |  148 ++++++++-------
>   src/providers/krb5/krb5_child_handler.c            |   59 +++++-
>   .../krb5/krb5_delayed_online_authentication.c      |   50 ++++--
>   src/providers/krb5/krb5_renew_tgt.c                |   18 +--
>   src/providers/ldap/ldap_auth.c                     |   90 ++++------
>   src/providers/ldap/sdap_async.c                    |    4 +-
>   src/providers/ldap/sdap_async.h                    |    7 +-
>   src/providers/ldap/sdap_async_connection.c         |   88 +++++----
>   src/providers/proxy/proxy.h                        |    7 +-
>   src/providers/proxy/proxy_auth.c                   |   14 +-
>   src/providers/proxy/proxy_child.c                  |   51 +++--
>   src/responder/pam/pam_LOCAL_domain.c               |   52 ++----
>   src/responder/pam/pamsrv_cmd.c                     |  159 +++++++++-------
>   src/tests/krb5_child-test.c                        |   13 +-
>   src/tests/sysdb-tests.c                            |    6 +-
>   src/util/authtok.c                                 |  195 ++++++++++++++++++++
>   src/util/authtok.h                                 |  180 ++++++++++++++++++
>   src/util/util.c                                    |    9 +
>   src/util/util.h                                    |    9 +
>   27 files changed, 950 insertions(+), 485 deletions(-)
>   create mode 100644 src/util/authtok.c
>   create mode 100644 src/util/authtok.h
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>

Hi,
thanks. I'm seeing following errors:

src/providers/krb5/krb5_auth.c: In function 'krb5_auth_store_creds':
src/providers/krb5/krb5_auth.c:394:13: warning: passing argument 2 of 
'sss_authtok_get_password' from incompatible pointer type [enabled by 
default]
In file included from ./src/providers/data_provider.h:44:0,
                  from ./src/providers/dp_backend.h:25,
                  from ./src/providers/krb5/krb5_auth.h:32,
                  from src/providers/krb5/krb5_auth.c:40:
./src/util/authtok.h:76:9: note: expected 'const char **' but argument 
is of type 'char **'
src/providers/krb5/krb5_auth.c:397:13: warning: passing argument 2 of 
'sss_authtok_get_password' from incompatible pointer type [enabled by 
default]
In file included from ./src/providers/data_provider.h:44:0,
                  from ./src/providers/dp_backend.h:25,
                  from ./src/providers/krb5/krb5_auth.h:32,
                  from src/providers/krb5/krb5_auth.c:40:
./src/util/authtok.h:76:9: note: expected 'const char **' but argument 
is of type 'char **'
src/providers/krb5/krb5_auth.c:414:9: error: 'tmp_ctx' undeclared (first 
use in this function)
src/providers/krb5/krb5_auth.c:414:9: note: each undeclared identifier 
is reported only once for each function it appears in

I'll send per patch review separately.




More information about the sssd-devel mailing list