[SSSD] [PATCH] Consolidation of functions that make realm upper-case

Jakub Hrozek jhrozek at redhat.com
Wed Aug 22 15:20:38 UTC 2012


On Wed, Aug 22, 2012 at 03:18:05PM +0200, Jakub Hrozek wrote:
> On Tue, Aug 21, 2012 at 04:48:08PM +0200, Ondrej Kos wrote:
> > Fixed
> > 
> > Function was modified to just return the given string as uppercase.
> > The part where the whole principal is being processed was restored
> > to it's previous state.
> > 
> > New patch is attached
> > 
> > Ondrej
> > 
> 
> Fix the braces in this hunk:
> > +
> > +    realm = talloc_strdup(memctx, name);
> > +    if (!realm)
> > +    {
> > +        return NULL;
> > +    }
> 
> and I'll ack :-)
> 
> See http://www.freeipa.org/page/Coding_Style#Conditions_and_Statements
> for the full guidelines.

Also these two new warnings seems to be caused by the patch:
src/providers/ipa/ipa_common.c:50:9: warning: unused variable 'i'
[-Wunused-variable]
src/providers/ad/ad_common.c:36:12: warning: unused variable 'i'
[-Wunused-variable]



More information about the sssd-devel mailing list