[SSSD] [PATCH] remove compilation warning: ret may be uninitialized

Stephen Gallagher sgallagh at redhat.com
Tue Aug 21 13:13:03 UTC 2012


On Tue, 2012-08-21 at 14:50 +0200, Pavel Březina wrote:
> On 08/21/2012 02:40 PM, Stephen Gallagher wrote:
> > On Tue, 2012-08-21 at 14:04 +0200, Pavel Březina wrote:
> >> I found this warning while reviewing Michal's transaction patch.
> >>
> >> It was introduced in 9356e8f50436724e985d9a8f5d4f2bc0f5b837bc and it is
> >> visible with the following CFLAGS:
> >> -m64 -mtune=generic -O3 -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wall
> >> -Wextra -Wno-sign-compare -Wno-unused-parameter
> >
> > Nack. Please don't default to EOK. It makes it hard to keep track of it.
> > Instead, assign it EOK just before the "done:" label. (i.e. "If we got
> > here, we're OK")
> 
> Good point. New patch is attached.


Ack.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120821/b75f3579/attachment.sig>


More information about the sssd-devel mailing list