[SSSD] [PATCH] (2nd wave) Removing bad examples of usage of, sysdb_transaction_start/commit/end functions and making it, more consistent (all files except of src/db/sysdb_*.c)

Michal Židek mzidek at redhat.com
Tue Aug 21 11:40:27 UTC 2012


On 08/21/2012 10:39 AM, Pavel Březina wrote:
> On 08/20/2012 05:03 PM, Michal Židek wrote:
>> This is the second and final patch to make the usage of
>> sysdb_transaction_* functions
>> more consistent. There is still one place in the code left, where it is
>> not as it should be,
>> but it is related to a separate ticket (
>> https://fedorahosted.org/sssd/ticket/1370 ) and
>> should be done as a separate patch.
>>
>> The patch is attached.
>>
>> Thanks
>> Michal
>
> Nack.
>
> There are few places, where you use the original numeric debug levels.
> Please, replace those with SSSDBG macros.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


All new debug messages added in that patch are using SSSDBG macros. I 
did not change already
existing messages, because it is not what I wanted to do in this patch. 
But you are probably right, it
should be consistent. It is fixed in the new attached patch for messages 
related to sysdb_transaction_* functions, but the rest should be 
probably done as separate patch (if needed).

Thanks
Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-2nd-wave-Removing-bad-examples-of-usage-of-sysdb_tra.patch
Type: text/x-patch
Size: 37221 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120821/481e476b/attachment.bin>


More information about the sssd-devel mailing list