[SSSD] [PATCH] accept_fd_handler: add missing return

Sumit Bose sbose at redhat.com
Mon Aug 20 09:30:03 UTC 2012


Hi,

I just found this missing return while looking for a different issue.

I wonder why Coverity and friends didn't found it. Is there a way to
tell Coverity to handle talloc_free() similar for free()?

bye,
Sumit
-------------- next part --------------
From 88dae3d96895911bf0614b5daa5d0cb2fabbfa37 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Mon, 20 Aug 2012 11:21:51 +0200
Subject: [PATCH] accept_fd_handler: add missing return

---
 src/responder/common/responder_common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c
index 438ca2c..37a08d9 100644
--- a/src/responder/common/responder_common.c
+++ b/src/responder/common/responder_common.c
@@ -455,6 +455,7 @@ static void accept_fd_handler(struct tevent_context *ev,
         talloc_free(cctx);
         DEBUG(2, ("Failed to queue client handler%\n",
                 accept_ctx->is_private ? " on privileged pipe" : ""));
+        return;
     }
 
     cctx->ev = ev;
-- 
1.7.7.6



More information about the sssd-devel mailing list