[SSSD] [PATCH] Removing bad examples of usage of, sysdb_transaction_start/commit/end functions and making it, more consistent. (files src/db/sysdb_*.c)

Michal Židek mzidek at redhat.com
Wed Aug 15 15:52:02 UTC 2012


I worked on solution of ticket https://fedorahosted.org/sssd/ticket/1150 
and I already had
some solutions with macros, but I found them ugly and obfuscated or not 
generic enough, so
they could not be used on all places where we use sysdb_transaction 
functions.

So I decided not to implement any wrapper macros around these functions 
(yet) and only
rewrite the places where we use sysdb_transactions to unify the way they 
are used (and to remove bad
examples of usage).

In this patch, I did it for files in src/db/. If this patch is OK, I'll 
try to spread this pattern to other modules
where sysdb_transaction_start/commit/cancel is used.

The patch is attached.

NOTE: Function sysdb_idmap_store_mappings looks like completely 
rewritten, but it is not. Except of
changes related to sysdb_transaction it had only bad indentation.

Thanks
Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Removing-bad-examples-of-usage-of-sysdb_transaction_.patch
Type: text/x-patch
Size: 26393 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120815/aa319225/attachment.bin>


More information about the sssd-devel mailing list