[SSSD] [PATCH] Backward GOTOs rewritten into do-while loops.

Jakub Hrozek jhrozek at redhat.com
Thu Aug 9 10:07:00 UTC 2012


On Thu, Aug 09, 2012 at 11:11:56AM +0200, Ondrej Kos wrote:
> On 08/08/2012 06:10 PM, Jakub Hrozek wrote:
> >On Wed, Aug 08, 2012 at 09:24:50AM -0400, Simo Sorce wrote:
> >>Ack from me, however if you do not like the if statement inside the loop
> >>you can also change it to be:
> >>
> >>while (true) {
> >>status = ....
> >>if (status != NSS_STATUS_TRYAGAIN) {
> >>break;
> >>}
> >>....
> >>}
> >>
> >
> >Ondrej, please let me know whether you're going to make this change or
> >not. I don't really mind personally, both forms are fine from my point
> >of view.
> I'd leave it this way.

Fair enough, ack from me, too and pushed to master.



More information about the sssd-devel mailing list