[SSSD] [PATCH] Fix LOCAL domain lookups

Stephen Gallagher sgallagh at redhat.com
Wed Aug 8 14:36:02 UTC 2012


On Wed, 2012-08-08 at 16:24 +0200, Jakub Hrozek wrote:
> On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote:
> > This bug was probably introduced with the subdomain patches. The
> > problem was that sss_dp_get_domains_send() is called even for the local
> > provider. There are certainly many possible solutions of this issue. I
> > decided to modify sss_dp_issue_request() to call the callback
> > immediately if it is issued for local domain. This way, I believe, we
> > can avoid further problems with issuing request for local domains.
> 
> I don't think this is the best solution.
> 
> First, it leaves the check_provider of the per-domain structures we use
> in responders around while duplicating the same functionality in the DP.
> At the very least, the patch should remove the "check_provider" tests from
> the existing loops.
> 
> What I think would be even better solution is to
>     1) in the RC just fix the subdomains code so that it shortcuts or
>     doesn't run at all for LOCAL lookups.
>     2) The work we'll be doing later on #1126 would merge all the loops
>     into one common place.
> 
> This approach would have the benefit of all the checks being done at one
> common place, so that we don't forget to add them like we did in the
> subdomains case and at would be faster at the same time because it
> wouldn't even contact the DP at all, much like it's done now in the
> separate loops.

I think it might be time to more seriously consider decoupling the LOCAL
provider into a real provider type, instead of having so many
special-cases throughout the code (i.e. if !local then goto data
provider)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120808/41fbdb63/attachment.sig>


More information about the sssd-devel mailing list