[SSSD] [PATCH] Backward GOTOs rewritten into do-while loops.

Ondrej Kos okos at redhat.com
Wed Aug 8 09:05:13 UTC 2012


+FMT fix

On 08/08/2012 10:53 AM, Jakub Hrozek wrote:
> On Wed, Aug 08, 2012 at 08:56:59AM +0200, Ondrej Kos wrote:
>> Strange, I've created the patch with this alias, so patience flag
>> should be on
>> alias gfp='git format-patch -M -C --patience --full-index'
>>
>> As for the while -> do-while, if I'd do that, then it would need
>> another condition
>> if (status == NSS_STATUS_TRYAGAIN)
>> for the block of code which adjusts buffer size on lines 1250-1263.
>> It seemed a bit pointless when you can use just one condition in
>> while. So, should i leave it this way, or really use do-while with
>> additional if?
>>
>> Ondrej
>
> The patch cannot be compiled, probably after a misplaced "fmt"
> reformatting which broke multi-line DEBUG messages.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>


-- 
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech

cell:  +420-736-417-909
phone: +420-532-294-558
ext.:  82-62558
irc:   okos @ #brno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Backward-GOTOs-rewritten-into-do-while-loops.patch
Type: text/x-patch
Size: 19018 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120808/f3de36f0/attachment.bin>


More information about the sssd-devel mailing list