[SSSD] [PATCH] First Boot Seed Tool

Jakub Hrozek jhrozek at redhat.com
Wed Aug 1 19:16:43 UTC 2012


On Wed, Aug 01, 2012 at 06:29:13PM +0200, Pavel Březina wrote:
> On 1.8.2012 18:18, Nick Guay wrote:
> >On 01/08/12 12:00, Pavel Březina wrote:
> >>Great! One final nack though, but that would be a quick fix.
> >>
> >>283: move those #endif to the macros they belong to:
> >>#ifndef BUFSIZE
> >>#define BUFSIZE 1024
> >>#endif
> >>
> >>#ifndef PASS_MAX
> >>#define PASS_MAX 64
> >>#endif
> >>
> >>seed_interactive_input(): you don't test for NULL when strdup
> >>
> >>And remove groups and addgroups from uctx structure, popt, interactive
> >>input.
> >>
> >>Thanks,
> >>Pavel.
> >>
> >
> >Thanks, fixed.
> 
> Ack!

Pushed to master.

Great work, Nick!



More information about the sssd-devel mailing list