[SSSD] [PATCH] First Boot Seed Tool

Nick Guay nguay at redhat.com
Wed Aug 1 16:18:47 UTC 2012


On 01/08/12 12:00, Pavel Březina wrote:
> Great! One final nack though, but that would be a quick fix.
>
> 283: move those #endif to the macros they belong to:
> #ifndef BUFSIZE
> #define BUFSIZE 1024
> #endif
>
> #ifndef PASS_MAX
> #define PASS_MAX 64
> #endif
>
> seed_interactive_input(): you don't test for NULL when strdup
>
> And remove groups and addgroups from uctx structure, popt, interactive 
> input.
>
> Thanks,
> Pavel.
>

Thanks, fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-First-boot-sss_seed-tool.patch
Type: text/x-patch
Size: 34933 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120801/a9e7e87e/attachment.bin>


More information about the sssd-devel mailing list