[SSSD] [PATCH][SET] Cleanups and subdomain refactoring

Jakub Hrozek jhrozek at redhat.com
Wed Aug 1 11:29:15 UTC 2012


On Tue, Jul 31, 2012 at 08:33:05AM -0400, Simo Sorce wrote:
> On Tue, 2012-07-31 at 13:25 +0200, Jakub Hrozek wrote:
> > On Mon, Jul 23, 2012 at 05:38:50PM -0400, Simo Sorce wrote:
> > > As aprt of the work for ticket #1380 I have created a long patchset that
> > > cleans up and refactors some of the ipa subdomain work.
> > > 
> > > This is in order to be able to refresh subdomains on a periodic basis
> > > and not just when the nss service pings in and also to provide a place
> > > where to trigger an update of the krb5.conf file only when necessary.
> > > 
> > > The patchset is long (16 patches) but each patch should be small enough
> > > to be easy to review.
> > > 
> > > The patches have been partially tested, the internal sysdb tests pass,
> > > and I did test on a setup environment, but the setup env was not up to
> > > date, so the test was not complete.
> > > 
> > > However I am confident that they should work (last famous word) and I am
> > > posting them so that Jakub can take over the second part of the work and
> > > add the code that actually saves the domain_realm info in a file.
> > > 
> > > Simo.
> > > 
> > 
> > I tested the patches and they work good.
> > 
> > In the "Change refreshing of subdomains" patch, what is the purpose of
> > "handled"? It's never assigned to and it's declared using the C-99 dynamic
> > array feature.
> > 
> > The patches only change to using ldb_msg_add_string with bare strings in
> > the subdomains code. We should also check other modules, like sysdb_ops.c
> > 
> > The rest looks good to me and works fine, so once the "handled" variable
> > is removed or fixed, I'll ack.
> 
> Thanks a lot for pointing this out.
> Turns out for some reason the line that actually sets handled elements
> went missing.
> 
> I revved up just that patch, here it is.
> 
> Simo.

Thank you, Ack.



More information about the sssd-devel mailing list