[SSSD] [PATCH] murmurhash: Relax inline requirement

Stephen Gallagher sgallagh at redhat.com
Tue Apr 24 18:28:02 UTC 2012


On Tue, 2012-04-24 at 15:54 +0200, Jakub Hrozek wrote:
> On Tue, Apr 24, 2012 at 09:40:54AM -0400, Stephen Gallagher wrote:
> > On Tue, 2012-04-24 at 09:30 -0400, Stephen Gallagher wrote:
> > > Building SSSD on GCC 4.7 produces a new warning:
> > > 
> > > "../src/util/murmurhash3.c:47:17: error: always_inline function might
> > > not be inlinable [-Werror=attributes]"
> > > 
> > > This patch removes always_inline and replaces it with simply
> > > 'inline' (which GCC may remove if it deems it appropriate).
> > > 
> > > Simo, can you confirm that there's no problem with this? I think it
> > > should be safe.
> > 
> > 
> > On further investigation, I discovered
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49139#c1 which states that
> > the use of '_attribute__((always_inline))' without also specifying the
> > 'inline' keyword is incorrect. It implies that in GCC 4.6 and earlier it
> > resulted in not inlining.
> > 
> > Corrected patch ensures inlining.
> 
> Ack, I also tried to compile with -Winline and saw no warnings, so I
> assume the inlining went OK this time.

Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120424/07fe10ca/attachment.sig>


More information about the sssd-devel mailing list