[SSSD] Support for subdomains - stage 1

Stephen Gallagher sgallagh at redhat.com
Tue Apr 24 13:20:33 UTC 2012


On Tue, 2012-04-24 at 08:51 -0400, Stephen Gallagher wrote:
> On Tue, 2012-04-24 at 13:23 +0200, Jan Zelený wrote:
> > > On Wed, Apr 18, 2012 at 03:22:03PM +0200, Jan Zelený wrote:
> > > > > On Fri, Apr 13, 2012 at 08:24:18AM +0200, Jan Zelený wrote:
> > > > > > > On Thu, Apr 12, 2012 at 09:52:14PM +0200, Jan Zeleny wrote:
> > > > > > > > Jakub Hrozek <jhrozek at redhat.com> wrote:
> > > > > > > > > On Tue, Apr 10, 2012 at 12:38:31AM -0400, Jakub Hrozek wrote:
> > > > > > > This works fine, but the new option should be added to the
> > > > > > > configAPI (sorry, I hope this would be the last iteration).
> > > > > > 
> > > > > > My mistake, I knew I'm missing something but late hour was stronger
> > > > > > than my will to re-check everything.
> > > > > > 
> > > > > > > The DEBUG message level is set to SSSDBG_CRIT_FAILURE, which seems
> > > > > > > quite high because this DEBUG message is emited for any back end
> > > > > > > which does not support subdomains which is everything but IPA.
> > > > > > > This should be a MINOR failure at best, maybe even lower.
> > > > > > 
> > > > > > I will change this in separate patch
> > > > > > 
> > > > > > > Also, instead of defaulting to "not set", would it be a good idea
> > > > > > > to default to "ipa" in the IPA provider and maybe check during the
> > > > > > > first request if subdomains are enabled on the server  -- provided
> > > > > > > that runtime detection  is possible which I honestly don't know.
> > > > > > > That way the clients wouldn't have to be reconfigured if trusts
> > > > > > > are added on the server.
> > > > > > 
> > > > > > I'm not completely sure about this since Sumit did the part where
> > > > > > SSSD communicates with IPA. I will discuss it with him once he is
> > > > > > back from vacation. I'll send the patch set then.
> > > > > 
> > > > > yes, please activate subdomains for the IPA provider by default, the
> > > > > detection if subdomains are available is always done at runtime.
> > > > 
> > > > After consultation with Jakub, we agreed to move this task to separate
> > > > ticket.
> > > > 
> > > > https://fedorahosted.org/sssd/ticket/1308
> > > > 
> > > > I suppose that the change of debug level stated above won't be necessary
> > > > after this change.
> > > > 
> > > > I'm sending the (hopefully) last iteration of patches in attachment.
> > > > 
> > > > Thanks
> > > > Jan
> > > 
> > > There were two merge problems in patches 02 and 09.
> > > 
> > > 
> > ======================================================================
> > > FAIL: testListOptions (__main__.SSSDConfigTestSSSDDomain)
> > > ----------------------------------------------------------------------
> > > Traceback (most recent call last):
> > >   File "././src/config/SSSDConfigTest.py", line 518, in testListOptions
> > >     option)
> > > AssertionError: Option [subdomains_provider] unexpectedly found
> > 
> > I encountered only one, the other one was resolved automatically. Attached is 
> > the patch set based on top of current master.
> > 
> > Thanks
> > Jan
> 
> 
> Nack:
> 
> make  check-TESTS
> make[3]: Entering directory `/dev/shm/build/rpmbuild/BUILD/sssd-1.8.90'
> .......
> ----------------------------------------------------------------------
> Ran 7 tests in 0.034s
> 
> OK
> .....F...F...
> ======================================================================
> FAIL: testListOptions (__main__.SSSDConfigTestSSSDDomain)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "././src/config/SSSDConfigTest.py", line 518, in testListOptions
>     option)
> AssertionError: Option [subdomains_provider] unexpectedly found
> 
> ======================================================================
> FAIL: testRemoveProvider (__main__.SSSDConfigTestSSSDDomain)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "././src/config/SSSDConfigTest.py", line 845, in
> testRemoveProvider
>     option)
> AssertionError: Option [subdomains_provider] unexpectedly found
> 
> ----------------------------------------------------------------------
> Ran 13 tests in 0.068s
> 
> FAILED (failures=2)
> 


I fixed the above SSSDConfigTest.py issue (squashed into patch 0009,
attached) and pushed them all to master.

Great work Jan and Sumit!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-data-provider-added-subdomains.patch
Type: text/x-patch
Size: 12558 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120424/d285811f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120424/d285811f/attachment.sig>


More information about the sssd-devel mailing list