[SSSD] [PATCHES] SSH: Support hashed known_hosts

Jakub Hrozek jhrozek at redhat.com
Mon Apr 23 15:55:40 UTC 2012


On Mon, Apr 23, 2012 at 03:49:25PM +0200, Jan Cholasta wrote:
> On 23.4.2012 13:22, Jan Cholasta wrote:
> >On 23.4.2012 09:21, Jakub Hrozek wrote:
> >>On Thu, Apr 19, 2012 at 11:10:13AM +0200, Jan Cholasta wrote:
> >>>Hi,
> >>>
> >>>the attached patches add support for host name and address hashing
> >>>in the known_hosts file, see
> >>><https://fedorahosted.org/sssd/ticket/1203>.
> >>>
> >>>[PATCH 1/2] UTIL: Add HMAC-SHA-1 function
> >>
> >>Can you add a couple of comments?
> >
> >Done.
> >
> >>
> >>There are some magic values used that could use explaining:
> >>>+ for (i = 0; i< HMAC_SHA1_BLOCKSIZE; i++) {
> >>>+ okey[i] = ikey[i] ^ 0x5c;
> >>>+ ikey[i] ^= 0x36;
> >>>+ }
> >>
> >>A unit test would also be nice.
> >
> >Added.
> >
> >>
> >>>
> >>>[PATCH 2/2] SSH: Add support for hashed known_hosts
> >>>
> >>
> >>The code looks OK, but does not apply on master, so I haven't been able
> >>to test it.
> >
> >Rebased the patch.
> >
> >Updated patches attached.
> >
> >Honza
> >
> 
> Fixed warnings in the test.

Ack, works fine.



More information about the sssd-devel mailing list