[SSSD] [PATCH] Another code cleanup

Jan Zelený jzeleny at redhat.com
Thu Apr 19 07:46:14 UTC 2012


> After some recent cleanup patches I sent, I'd like to do one more change,
> this time a more significant one. I'd like to propose attached patch which
> will delete a code path in sdap_async_groups.c which is not exactly dead
> but it is unnecessary IMO. I already tried to do some testing with IPA
> server and nested groups on it and everything seems to be working as
> expected.
> 
> However since this is not exactly trivial change, I'd like your comments.
> The new approach basically utilizes the "nesting" code path even when
> nesting is explicitly set to zero.
> 
> In the original approach a query is sent to the server for each member of
> the original group. A filter objectclass=posixAccount is used to make sure
> that groups are not returned from the server. In the new approach the same
> amount of queries is sent to the server, the only difference is that
> server is returning more results. If necessary I believe this can be
> optimized by several simple ifs. Of course in case of deref this can be
> optimized only to some degree (lowering the amount of entities we want to
> ask for, therefore lowering the possibility that deref will be actually
> used).

Self-nack. There is an issue when using enumeration which I have yet to figure 
out.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120419/9d2dbd33/attachment.sig>


More information about the sssd-devel mailing list