[SSSD] Removed a block of dead code from sdap_async_groups.c

Stephen Gallagher sgallagh at redhat.com
Wed Apr 18 14:47:37 UTC 2012


On Wed, 2012-04-18 at 12:02 +0200, Jakub Hrozek wrote:
> On Tue, Apr 17, 2012 at 02:47:16PM +0200, Jan Zeleny wrote:
> > Jakub Hrozek <jhrozek at redhat.com> wrote:
> > > On Tue, Apr 17, 2012 at 11:00:12AM +0200, Jan Zelený wrote:
> > > > #111
> > > > I found this while closely going through the file to implement ghost
> > > > users. After discovering this, I re-checked it twice to be sure. To
> > > > enter the block of code, it would require RFC2307 and populate_members
> > > > set to false.
> > > > 
> > > > But when you go through the file, the only place where sdap_save_groups()
> > > > is called for RFC2307 is in sdap_get_groups_done() and it is called with
> > > > populate_users = true.
> > > 
> > > Ack
> > > 
> > > > #112
> > > > Because of the change in previous patch, there is only one place where
> > > > this function is called and it is bound with RFC230bis.
> > > 
> > > Ack
> > > 
> > > You can also remove sysdb_attrs_users_from_ldb_vals() now
> > 
> > Here are all three patches
> > 
> > Jan
> 
> Ack

Pushed to master and sssd-1-8.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120418/2beaff13/attachment.sig>


More information about the sssd-devel mailing list