[SSSD] [PATCHES] Two minor fixes in LDAP provider

Jakub Hrozek jhrozek at redhat.com
Wed Apr 18 10:14:50 UTC 2012


On Tue, Apr 17, 2012 at 03:23:33PM +0200, Jan Zeleny wrote:
> #114:
> There is no real issue in that code at this moment but it's only a lucky 
> coincidence. If there was another element in group_attrs before member, the 
> result would be SIGABRT.
> 

The patch is correct but not as bad as it seems, the mem_ctx parameter is
not used if the memory was previously allocated, only if ptr is NULL or
size is 0 (but it seems the man page for talloc_realloc says otherwise..)

> #115:
> Not really a memleak because of the memory hierarchy but I think it's nice to 
> clean up memory when rewriting a pointer.

Ack

> 
> Thanks
> Jan




More information about the sssd-devel mailing list