[SSSD] [PATCH][PRELIMINARY] sudo: send username and uid while requesting default options

Pavel Březina pbrezina at redhat.com
Fri Apr 13 10:46:01 UTC 2012


On 03/26/2012 09:47 PM, Jakub Hrozek wrote:
> On Mon, Mar 19, 2012 at 02:46:02PM +0100, Pavel Březina wrote:
>> https://fedorahosted.org/sssd/ticket/1239
>>
>> [PATCH 1/2]
>> Finally removes EOK constant from sudo api header. It is not used in
>> the SUDO code so it does not require their changes.
>>
>
> Looks good to me, it'w weird to use EOK in an external header (even
> though it is correctly defined).
>
> (Note: this patch shouldn't be pushed even though I don't have any
> comments. It is an ABI break and we need to coordinate with Daniel K.)
>
>> [PATCH 2/2]
>> This does what is requested in the ticket. It seems to be very huge but
>> in fact it is mainly changing the variable. Basically I tried to get
>> rid of domain ctx where possible, leave it only in initgroups part and
>> use command ctx elsewhere.
>>
>
> Still, it is hard to review the huge patch. Can you split it into
> smaller ones? What about creating one that removes the duplication
> between _get_sudorules and _get_defaults, one that converts to using
> cmdctx and one that adds the uid support?

The patches are attached.

I want to get those patches acked because I need to deliver the updated
interface to Dan so he can update the sudo binary.

It does not implement the in-memory cache (yet? :-)) due to the 
discussion with simo.

The patches expects "sudo api: check sss_status instead of errnop in 
sss_sudo_send_recv_generic()" (already acked on the list and waiting to 
be pushed).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-sudo-api-remove-EOK.patch
Type: text/x-patch
Size: 3447 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120413/71ced86a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sudo-responder-remove-code-duplication-in-commands.patch
Type: text/x-patch
Size: 24059 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120413/71ced86a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-sudo-responder-get-rid-of-dctx-where-possible.patch
Type: text/x-patch
Size: 19604 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120413/71ced86a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-sudo-sysdb-make-sysdb_get_sudo_user_info-more-config.patch
Type: text/x-patch
Size: 3224 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120413/71ced86a/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-sudo-api-send-uid-username-and-domainname.patch
Type: text/x-patch
Size: 32038 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20120413/71ced86a/attachment-0004.bin>


More information about the sssd-devel mailing list