[SSSD] [PATCH] improve handling of users with multiple names

Stephen Gallagher sgallagh at redhat.com
Tue Sep 27 15:39:51 UTC 2011


On Mon, 2011-09-26 at 18:20 +0200, Jakub Hrozek wrote:
> 
> After discussing the approach with Simo on #sssd, I added a comment
> explaining what sysdb_attrs_get_aliases() does.
> 
> New patches attached.

Patch 0001: What's the value of returning NULL for the aliases list if
there are none? Wouldn't it simplify the code design at consumption by
just iterating through a zero-length array? (Looking at its use in patch
0003)

Not really a nack, but I'm somewhat wary of keeping separate codepaths.

Patch 0002:
As a general style issue, please handle errors from sysdb_search_entry()
first and then proceed with the rest of the function. This way the large
part of the function is not indented unnecessarily.

Similary to my comment in patch 0001, I don't see the benefit to setting
the pointer to NULL.
If ret == ENOENT, just set direct_sysdb_count = 0 and continue. The loop
will work itself out, and you'll just return an array of zero entries.

Patch 0003: Ack.


Patch 0004: Ack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110927/36ab382b/attachment.sig>


More information about the sssd-devel mailing list