[SSSD] [PATCH] Do not access memory out of bounds

Sumit Bose sbose at redhat.com
Wed Sep 7 11:50:22 UTC 2011


On Wed, Sep 07, 2011 at 01:30:54PM +0200, Sumit Bose wrote:
> Hi,
> 
> while testing HBAC Shanks found an issue (bz736314) while processing
> external hosts. This patch should fix it.

The patch was incomplete, new version attached.

bye,
Sumit

> 
> bye,
> Sumit
-------------- next part --------------
From f9f848c4198b146972a969ba6e819d4d890fcbd8 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 7 Sep 2011 13:15:49 +0200
Subject: [PATCH] Do not access memory out of bounds

---
 src/providers/ipa/ipa_hbac_hosts.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/providers/ipa/ipa_hbac_hosts.c b/src/providers/ipa/ipa_hbac_hosts.c
index 70be90e..31e96e5 100644
--- a/src/providers/ipa/ipa_hbac_hosts.c
+++ b/src/providers/ipa/ipa_hbac_hosts.c
@@ -499,10 +499,10 @@ hbac_shost_attrs_to_rule(TALLOC_CTX *mem_ctx,
             goto done;
         }
 
-        for (idx = host_count; idx <= host_count + el->num_values; idx++) {
+        for (idx = host_count; idx < host_count + el->num_values; idx++) {
             shosts->names[idx] =
                     talloc_strdup(shosts->names,
-                                  (const char *)el->values[idx].data);
+                               (const char *)el->values[idx - host_count].data);
             if (shosts->names[idx] == NULL) {
                 ret = ENOMEM;
                 goto done;
-- 
1.7.6



More information about the sssd-devel mailing list