[SSSD] [PATCH] Steal result onto mem_ctx in sdap_initgr_nested_get_direct_parents

Jakub Hrozek jhrozek at redhat.com
Mon Oct 31 12:56:17 UTC 2011


The -Wunused cleanup revealed one real bug. It's been this way since 1.5
but sooner or later this would hit someone.
-------------- next part --------------
>From f3718a0c6a55893169a3262f195eec5f11a5df16 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Mon, 31 Oct 2011 13:03:33 +0100
Subject: [PATCH] Steal result onto mem_ctx in
 sdap_initgr_nested_get_direct_parents

---
 src/providers/ldap/sdap_async_initgroups.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c
index 7bcd90fa2b7982ef30d03d896bf77fa2d9101a66..81a943efefd81b3c4392eb60c7f2b587e2ddd64a 100644
--- a/src/providers/ldap/sdap_async_initgroups.c
+++ b/src/providers/ldap/sdap_async_initgroups.c
@@ -1090,7 +1090,6 @@ static int sdap_initgr_nested_get_direct_parents(TALLOC_CTX *mem_ctx,
     tmp_ctx = talloc_new(NULL);
     if (!tmp_ctx) return ENOMEM;
 
-
     direct_groups = talloc_zero_array(tmp_ctx, struct sysdb_attrs *,
                                       ngroups + 1);
     if (!direct_groups) {
@@ -1132,7 +1131,7 @@ static int sdap_initgr_nested_get_direct_parents(TALLOC_CTX *mem_ctx,
 
     DEBUG(9, ("The group [%s] has %d direct parents\n", orig_dn, ndirect));
 
-    *_direct_parents = direct_groups;
+    *_direct_parents = talloc_steal(mem_ctx, direct_groups);
     *_ndirect = ndirect;
     ret = EOK;
 done:
-- 
1.7.6.4



More information about the sssd-devel mailing list