[SSSD] [PATCH] RESPONDER: Fix segfault in sss_packet_send()

Stephen Gallagher sgallagh at redhat.com
Tue Oct 25 20:16:15 UTC 2011


On Tue, 2011-10-25 at 22:11 +0200, Jakub Hrozek wrote:
> On Tue, Oct 25, 2011 at 03:25:35PM -0400, Stephen Gallagher wrote:
> > There are several places (all error-handling) where sss_cmd_done()
> > is called with no response packet created. As a short-term
> > solution, we need to check whether the packet is NULL and simply
> > return EINVAL. client_send() (the consumer) will then forcibly
> > disconnect the client (which will return PAM_SYSTEM_ERR to the
> > client).
> > 
> > This is a quick fix for
> > https://bugzilla.redhat.com/show_bug.cgi?id=748924
> > 
> > We don't have enough information (or steps to reproduce) to trace back
> > the processing to its origin, so the best thing we can do for the moment
> > is to simply prevent the crash. The client will receive an error, but
> > the SSSD will continue to function.
> 
> Ack
> 
> would it make sense to add a loud DEBUG() debug message so we are notified
> when this hits again?

If you follow it through, there's already a level 0 message that the
communication failed. So I think we're okay there.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111025/71674b9d/attachment.sig>


More information about the sssd-devel mailing list