[SSSD] [PATCH] SysDB lastUpdate can be passed in

Jakub Hrozek jhrozek at redhat.com
Wed Oct 12 09:10:17 UTC 2011


On Mon, Oct 10, 2011 at 04:40:01PM +0200, Pavel Březina wrote:
> Dne 19.9.2011 22:17, Jakub Hrozek napsal(a):
> >On Mon, Sep 19, 2011 at 01:31:46PM +0200, Pavel Březina wrote:
> >>https://fedorahosted.org/sssd/ticket/836
> >
> >Nack,
> >
> >this is a good start, but this patch only deals with the sysdb API part.
> >There needs to be a second patch that actually uses it.
> >
> >Large transactions in src/providers/ldap/sdap_async_* and the proxy provider,
> >especially large group membership processing needs to call time() and pass
> >the result as a value of lastUpdate.
> >
> >Nitpick - can you make sure your mail client sends patches base64
> >encoded?
> 

In general, the patch looks good. I just have two comments:

Would it make sense to pass a timestamp from netgr_translate_members_done()
to sdap_save_netgroup() to sysdb_add_netgroup() as well?

Also, the commit message seems confusing to me.

> I can't find how (I'm using Thunderbird).

This issue has been solved off-list




More information about the sssd-devel mailing list