[SSSD] [PATCH] Fix two small bugs in group dereferencing

Jakub Hrozek jhrozek at redhat.com
Thu Nov 24 12:18:07 UTC 2011


Noticed this while working on the dereference support in IPA initgroups
-------------- next part --------------
From 2baf06d9df9f762524446bd1a377251a3f764ae8 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 18 Nov 2011 21:21:04 +0100
Subject: [PATCH] Fix two small bugs in group dereferencing

---
 src/providers/ldap/sdap_async_groups.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c
index 11f6b5c7db1d69cc1e0fa20bf452335e1a222153..ead3fd544ae74923332c0a3780c2454845b5f1e6 100644
--- a/src/providers/ldap/sdap_async_groups.c
+++ b/src/providers/ldap/sdap_async_groups.c
@@ -1938,7 +1938,10 @@ static struct tevent_req *sdap_nested_group_process_send(
 
     if (sdap_has_deref_support(state->sh, state->opts)) {
         state->derefctx = talloc_zero(state, struct sdap_deref_ctx);
-        if (!state->derefctx) goto immediate;
+        if (!state->derefctx) {
+            ret = ENOMEM;
+            goto immediate;
+        }
 
         ret = sysdb_attrs_get_string(group, SYSDB_ORIG_DN,
                                      &state->derefctx->orig_dn);
@@ -2849,7 +2852,7 @@ static void sdap_nested_group_process_deref(struct tevent_req *subreq)
     if (ret != EOK && ret != ENOENT) {
         tevent_req_error(req, ret);
         return;
-    } else if (ret == ENOENT || state->derefctx->deref_result == 0) {
+    } else if (ret == ENOENT || state->derefctx->deref_result == NULL) {
         /* Nothing could be dereferenced. Done. */
         tevent_req_done(req);
         return;
-- 
1.7.7.3



More information about the sssd-devel mailing list