[SSSD] [PATCH] Two deref fixes

Jan Zelený jzeleny at redhat.com
Tue Nov 1 15:37:38 UTC 2011


> On Tue, Nov 01, 2011 at 04:13:20PM +0100, Jan Zelený wrote:
> > > Simo was studying the dereference code lately and found two issues. #1
> > > is an important bug, #2 is more of a cosmetic issue.
> > > 
> > > [PATCH 1/2] Use LDAPDerefSpec properly
> > > ldap_create_deref_control_value expects an array of LDAPDerefSpec
> > > structures with LDAPDerefSpec.derefAttr == NULL as a sentinel. We were
> > > passing a single instance of a LDAPDerefSpec structure.
> > > 
> > > https://fedorahosted.org/sssd/ticket/1050
> > > 
> > > 
> > > [PATCH 2/2] Remove confusing do-while loop
> > > The deref processing would return a single control back. The do-while
> > > loop was harmless but confusing.
> > 
> > Nack,
> > as we discussed earlier, please use new debug levels in the second patch.
> > 
> > Jan
> 
> Done.

Ack to both

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111101/523a4519/attachment.sig>


More information about the sssd-devel mailing list