[SSSD] [PATCH] AD non-posix group handling

Jan Zeleny jzeleny at redhat.com
Fri May 27 21:02:06 UTC 2011


Stephen Gallagher <sgallagh at redhat.com> wrote:
> On Tue, 2011-05-24 at 11:16 +0200, Jan Zelený wrote:
> > Hi,
> > since Jakub's RFC2307bis patches are already pushed, I've revisited my AD
> > non- posix group handling patch:
> > 
> > 027
> > Added function for retrieving boolean value from sysdb attributes. This
> > function is then utilized in the second patch
> 
> Ack
> 
> > 028
> > This is the patch I sent before with all modifications which were
> > discussed
> 
> Nack.
> 
> The changes to the sysdb functions are breaking the unit tests.
> 
> As a general kindness to reviewers, please break this patch up into one
> that changes the sysdb group functions and one that implements these
> changes into the LDAP and NSS code. The sysdb change patch should also
> include the necessary unit test fixes.
> 
> In sdap_nested_group_process_send() you should 'goto immediate' if you
> fail to mark the group as non-posix.

The new patch set is attached. I did some testing and found some issues with 
previous patches, so these are a little different at some places.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-027-sysdb_attrs_get_bool.patch
Type: text/x-patch
Size: 2023 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110527/b2711173/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-028.1-non-posix-sysdb.patch
Type: text/x-patch
Size: 6119 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110527/b2711173/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-028.2-non-posix-ldap-nss.patch
Type: text/x-patch
Size: 12704 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110527/b2711173/attachment-0002.bin>


More information about the sssd-devel mailing list