[SSSD] [PATCHES] Allow changing log-level without restarting SSSD

Stephen Gallagher sgallagh at redhat.com
Thu May 5 16:58:24 UTC 2011


On Wed, 2011-05-04 at 17:00 +0200, Jakub Hrozek wrote:
> On 05/02/2011 08:28 PM, Stephen Gallagher wrote:
> > These patches are dependent on the patch provided in my earlier email
> > "Override config file debug_level with command-line"
> > 
> > Patch 0002: Create common sss_monitor_init()
> > 
> > This was implemented almost identically for both the responders
> > and the providers. It is easier to maintain as a single routine.
> > 
> > This patch also adds the ability to provide a private context to
> > attach to the sbus_connection for later use.
> > 
> > 
> 
> I think that sss_monitor_init() should either store conn into *mon_conn
> or we should remove the struct sbus_connection* from structures that
> contain them - they appear not to be used anywhere.
> 

Thanks for catching that. I forgot to assign it to the return variable.

I want the structs to have access to the monitor context, because at
some point it may be desirable for children of the monitor to query it,
rather than have all contact originate from the monitor.

New patches attached. (Patch 0002 is unchanged)

> > 
> > Patch 0003: Allow changing the log level without restart
> > 
> > We will now re-read the confdb debug_level value when processing
> > the monitor_common_logrotate() function, which occurs when the
> > monitor receives a SIGHUP.
> > 
> > 
> > 
> > For now, this can be tested by using ldbedit
> > on /var/lib/sss/db/confdb.ldb to change the debug_level values and then
> > send 'kill -HUP $(pidof sssd)'. In the future, I will write a
> > command-line tool to effect this change more easily.
> > 
> 
> This one looks good to me, ack

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Create-common-sss_monitor_init.patch
Type: text/x-patch
Size: 7472 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110505/80dd47c2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Allow-changing-the-log-level-without-restart.patch
Type: text/x-patch
Size: 12242 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110505/80dd47c2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110505/80dd47c2/attachment.sig>


More information about the sssd-devel mailing list