[SSSD] [PATCH] Select principal for GSSAPI authentication

Jan Zelený jzeleny at redhat.com
Wed Mar 30 13:41:59 UTC 2011


Stephen Gallagher <sgallagh at redhat.com> wrote:
> If SDAP_SASL_AUTHID is specified, then ONLY this auth ID is allowable.
> If the keytab doesn't contain it, we need to fail.
> 
> If SDAP_SASL_REALM is specified, then only the REALM portion is
> mandatory (if we have no entries for this realm in the keytab, we need
> to fail).

Yep, that's basically what I thought. In the new patch these conditions should 
be met

> And for the code review:
> 
> Nack.
> If the talloc_strdup() or talloc_asprintf() fails to create the return
> values in select_principal_from_keytab(), this should be an ENOMEM
> failure. We should not proceed with a value of NULL.

I suspected so. Corrected.

Thanks
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jzeleny-008-4-modify-principal-selection.patch
Type: text/x-patch
Size: 19301 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110330/8970b5a7/attachment.bin>


More information about the sssd-devel mailing list