[SSSD] [PATCH 029-032] Refactoring of sdap_async_accounts

Simo Sorce simo at redhat.com
Wed Jun 8 14:12:49 UTC 2011


On Wed, 2011-06-08 at 10:05 -0400, Stephen Gallagher wrote:
> On Wed, 2011-06-08 at 15:40 +0200, Jan Zelený wrote:
> > So here it is, a set of patches splitting file sdap_async_accounts and making 
> > some subsequent changes. If anyone has other ideas what could be changed, let 
> > me know.
> > 
> > I was in favor of splitting the file into 3, as Simo suggested:
> > sdap_async_users.c
> > sdap_async_groups.c
> > sdap_async_initgroups.c
> > 
> > This way three basic operations are separated, but they are not separated too 
> > much (otherwise a _common.c file would have to be present, since some routines 
> > are shared by code paths in different schemas).
> 
> 
> As previously stated, the biggest change I wanted to see was to have the
> initgroups() implementations separated out. There are completely
> different code-paths for RFC2307, RFC2307bis(standard) and
> RFC2307bis(memberOf). The latter two are very difficult to keep track of
> in a single source file.

I guess you are suggesting that the files should have been split into
something like:

sdap_async_rfc2307.c
sdap_async_rfc2307bis.c
sdap_async_ipa_memberof.c

with an additional sdap_async_common.c to hold some common functions.

Just to make it clear and avoid painful rewrites and more ack/nack
cycles.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list