[SSSD] [PATCH] silence compilation warnings on RHEL5

Stephen Gallagher sgallagh at redhat.com
Wed Jul 27 20:39:22 UTC 2011


On Wed, 2011-07-27 at 15:51 +0200, Jakub Hrozek wrote:
> On 07/27/2011 02:38 PM, Pavel Březina wrote:
> > https://fedorahosted.org/sssd/ticket/930
> > 
> > 
> 
> There's still warnings in some of the sss_ tools coming from assigning
> to a "char *" variable from a function returning "const char *". I'm not
> actually sure why this warning is only emitted on RHEL5, maybe a
> toolchain change? I'd like to avoid using discard_const_p()
> unconditionally on all platforms in this case.
> 
> Maybe someone might educate me -- what is the point of popt returning
> "const char *" if they expect the data to be freed with free(3)? I
> thought that traditionally, free functions accept non-const b/c they
> might modify the contents of the memory in the process.
> 
> I'd like to ACK this unless there are reservations about the warnings in
> the tools.

Those can be handled in a separate patch. Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110727/aa140fac/attachment.sig>


More information about the sssd-devel mailing list