[SSSD] [PATCH] Explicitly ignore groups with gidNumber=0

Jakub Hrozek jhrozek at redhat.com
Fri Jul 22 09:17:23 UTC 2011


On 07/22/2011 09:18 AM, Jan Zeleny wrote:
> Jakub Hrozek<jhrozek at redhat.com>  wrote:
>> On 07/21/2011 01:57 PM, Jan Zelený wrote:
>>>> https://fedorahosted.org/sssd/ticket/916
>>>
>>> Nack,
>>> please look at following lines, there are parts of code which might need
>>> update along with your changes:
>>>
>>> providers/ldap/sdap_async_accounts.cz : 728
>>> db/sysdb_ops.c : 1576
>>
>> Right - the problem would be if a group changed its gid from nonzero to
>> zero, the sysdb update would keep the original version. It's a corner
>> case but we'd better cover it. The problem is there even with non-posix
>> groups so I'm sending a separate fix.
>>
>> Two patches attached now.
>
> Nack,
> I think you tried to fix the issue we discussed yesterday at the wrong place.
> The place your patch 0001 is taking care of only needs comsmetic change (the
> condition is needlesly complicated. Something like if (posix_group&&
> OUT_OF_ID_RANGE(...)) will do, since now gid == 0 always implies posix_group
> == true.
>
>

Patch 0001 does not deal with gid=0 implying non-posix. That's what 
patch #2 does.

> The issue you are trying to fix should be fixed in sysdb_ops.c in the place we
> were looking at yesterday.
>

No, that would be wrong abstraction. The sysdb function does not need to 
know about posix/non-posix.



More information about the sssd-devel mailing list