[SSSD] [PATCH] fo_get_server_name() changes

Jan Zelený jzeleny at redhat.com
Wed Jul 20 11:16:43 UTC 2011


> Attached are two more-or-less cosmetic changes.
> 
> The current fo_get_server_name() always returns a string, and for
> example, if the name is not set, it returns "unknown name". While this
> is handy is cases like debug printing, I think that there should be a
> more low-level function that would just return NULL for no name set.
> 
> [PATCH 1/2] Rename fo_get_server_name to fo_get_server_str_name
> I think this name better reflects the nature of the function
> 
> [PATCH 2/2] fo_get_server_name() getter for a server name
> This new function returns the host name if set and NULL otherwise. It is
> much handier in tests (see the src/tests/fail_over-tests.c hunk for
> example). It also allows us to be more defensive in the resolve
> callbacks where it is no longer possible to construct an URI like
> 'ldap://"unknown server"', we would rather get an error message instead.

Ack to both.

Please note that these patches depend on Jakub's previous patch:
0002-Only-print-server-address-if-one-is-available.patch


Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110720/df8344aa/attachment.sig>


More information about the sssd-devel mailing list