[SSSD] [PATCH] Fix python HBAC bindings for python <= 2.4

Jakub Hrozek jhrozek at redhat.com
Wed Jul 13 10:17:05 UTC 2011


On 07/13/2011 11:57 AM, Alexander Bokovoy wrote:
> On 13.07.2011 12:56, Jakub Hrozek wrote:
>> On 07/13/2011 11:09 AM, Alexander Bokovoy wrote:
>>> Now, there is one concern -- admittedly, my fault as I haven't mention it:
>>> str(true) == 'True'
>>> str(false) == 'False'
>>>
>>> so they should be acceptable as well. You have them explicitly denied in
>>> the unit tests. Do we have any particular reason not to allow them?
>>>
>>> This is minor comment, other than that patches look good!
>>
>> No reason, my previous incarnation of the patch actually had
>> strcasecmp(str, "true") -- would that be preferable? Or would it be
>> better to only explicitly allow for instance true/True/TRUE?
> 
> I'd vote for strcasecmp() way (as in UTF-8 that should be the same as 
> for ASCII). I guess this is the case where some tolerance is good. ;)
> 

Agreed. New patches attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixes-for-python-HBAC-bindings.patch
Type: text/x-patch
Size: 8063 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110713/1f1c745c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-python-HBAC-bindings-for-python-2.4.patch
Type: text/x-patch
Size: 26622 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110713/1f1c745c/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110713/1f1c745c/attachment.sig>


More information about the sssd-devel mailing list