[SSSD] [PATCH] Escape IP address in kdcinfo

Jakub Hrozek jhrozek at redhat.com
Mon Jul 11 10:25:05 UTC 2011


On 07/05/2011 04:44 PM, Stephen Gallagher wrote:
> On Sun, 2011-07-03 at 03:50 +0200, Jakub Hrozek wrote:
>> On Sat, Jul 02, 2011 at 01:58:55AM +0200, Jakub Hrozek wrote:
>>> [PATCH 1/2] Move IP adress escaping from the LDAP namespace
>>> The function called sss_ldap_escape_ip_address() was actually no longer
>>> used for constructing LDAP URIs and was just polluting the namespace.
>>>
> 
> Minor nack:
> I realize this was a problem with the original code, but please do not
> use inline functions. Modern compilers are smart enough to automatically
> make a function inline where the gain in speed exceeds the loss due to
> increase in executable size. Usually they're smarter than the programmer
> at this.
> 
>>> [PATCH 2/2] Escape IP address in kdcinfo
>>>
>>> https://fedorahosted.org/sssd/ticket/909
>>
>> I found typos in debug messages and one case where we wouldn't free
>> tmp_ctx on failure. New patches are attached.
> 
> Ack.
> 
> 

New patches attached
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Move-IP-adress-escaping-from-the-LDAP-namespace.patch
Type: text/x-patch
Size: 3621 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110711/7b1dfa8b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Escape-IP-address-in-kdcinfo.patch
Type: text/x-patch
Size: 4511 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110711/7b1dfa8b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110711/7b1dfa8b/attachment.sig>


More information about the sssd-devel mailing list