[SSSD] [PATCH] Remove unused krb5_service structure member

Jakub Hrozek jhrozek at redhat.com
Sun Jul 3 01:49:19 UTC 2011


On Sat, Jul 02, 2011 at 02:00:01AM +0200, Jakub Hrozek wrote:
> Found this when working on the address escaping..the member seems to be
> unused.

A rebased patch on top of new versions of the escaping patches is
attached.
-------------- next part --------------
>From 5df093bbc090df0f2f01e0d088ed880afa89b0ff Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhrozek at redhat.com>
Date: Fri, 1 Jul 2011 22:52:19 +0200
Subject: [PATCH] Remove unused krb5_service structure member

---
 src/providers/ipa/ipa_common.c   |    2 --
 src/providers/krb5/krb5_common.c |    5 +----
 src/providers/krb5/krb5_common.h |    1 -
 3 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/src/providers/ipa/ipa_common.c b/src/providers/ipa/ipa_common.c
index 6d0d534..0fa1153 100644
--- a/src/providers/ipa/ipa_common.c
+++ b/src/providers/ipa/ipa_common.c
@@ -647,8 +647,6 @@ static void ipa_resolve_callback(void *private_data, struct fo_server *server)
     service->sdap->uri = new_uri;
     talloc_zfree(service->sdap->sockaddr);
     service->sdap->sockaddr = talloc_steal(service, sockaddr);
-    talloc_zfree(service->krb5_service->address);
-    service->krb5_service->address = talloc_steal(service, address);
 
     safe_address = sss_escape_ip_address(tmp_ctx,
                                          srvaddr->family,
diff --git a/src/providers/krb5/krb5_common.c b/src/providers/krb5/krb5_common.c
index 2a3e7c2..d8e4a7b 100644
--- a/src/providers/krb5/krb5_common.c
+++ b/src/providers/krb5/krb5_common.c
@@ -404,7 +404,7 @@ static void krb5_resolve_callback(void *private_data, struct fo_server *server)
         return;
     }
 
-    address = resolv_get_string_address(krb5_service, srvaddr);
+    address = resolv_get_string_address(tmp_ctx, srvaddr);
     if (address == NULL) {
         DEBUG(1, ("resolv_get_string_address failed.\n"));
         talloc_free(tmp_ctx);
@@ -428,9 +428,6 @@ static void krb5_resolve_callback(void *private_data, struct fo_server *server)
         return;
     }
 
-    talloc_zfree(krb5_service->address);
-    krb5_service->address = address;
-
     ret = write_krb5info_file(krb5_service->realm, safe_address,
                               krb5_service->name);
     if (ret != EOK) {
diff --git a/src/providers/krb5/krb5_common.h b/src/providers/krb5/krb5_common.h
index d1a90c8..670fd1a 100644
--- a/src/providers/krb5/krb5_common.h
+++ b/src/providers/krb5/krb5_common.h
@@ -76,7 +76,6 @@ struct tgt_times {
 
 struct krb5_service {
     char *name;
-    char *address;
     char *realm;
 };
 
-- 
1.7.5.4



More information about the sssd-devel mailing list