[SSSD] [PATCH] Fix return value check

Stephen Gallagher sgallagh at redhat.com
Wed Jan 19 14:55:50 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/19/2011 07:50 AM, Stephen Gallagher wrote:
> On 01/19/2011 07:42 AM, Sumit Bose wrote:
>> On Wed, Jan 19, 2011 at 06:49:26AM -0500, Stephen Gallagher wrote:
>> On 01/19/2011 06:42 AM, Sumit Bose wrote:
>>>>> On Wed, Jan 19, 2011 at 06:29:17AM -0500, Stephen Gallagher wrote:
>>>>> On 01/19/2011 06:16 AM, Sumit Bose wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> this patch fixes a typo which leads to irritation log messages.
>>>>>
>>>>>
>>>>> As a general rule, I prefer explicit (ret != EOK) checks. Yes, I know
>>>>> they're identical, but it reads better.
>>>>>
>>>>>> me too, but I tried to keep the style used in sdap_pam_auth_done().
>>>>>
> 
> 
>> Keeping to that style introduced this bug in the first place, I think :)
> 
> 
>>> this new patch should fixes the style issue, too
> 
> 
> Ack.
> 
> 

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEUEARECAAYFAk02+3YACgkQeiVVYja6o6M5IwCcCGvioby6v9URdZOqY2RbaOJP
P5EAmKpO1CAnVoMuHj4xl5ek5VpNfbw=
=kTUp
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list