[SSSD] [PATCH] Fix return value check

Sumit Bose sbose at redhat.com
Wed Jan 19 11:42:56 UTC 2011


On Wed, Jan 19, 2011 at 06:29:17AM -0500, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 01/19/2011 06:16 AM, Sumit Bose wrote:
> > Hi,
> > 
> > this patch fixes a typo which leads to irritation log messages.
> 
> 
> As a general rule, I prefer explicit (ret != EOK) checks. Yes, I know
> they're identical, but it reads better.

me too, but I tried to keep the style used in sdap_pam_auth_done().

bye,
Sumit

> 
> - -- 
> Stephen Gallagher
> RHCE 804006346421761
> 
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAk02yw0ACgkQeiVVYja6o6MX8ACfbQnBT+bzYpzdsIr+5RzhRuov
> ToUAn2AbyZQFN6Hy1sBcbUSX/eK3wbdJ
> =VNwd
> -----END PGP SIGNATURE-----
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel



More information about the sssd-devel mailing list