[SSSD] [PATCHES] Enumeration fixes

Stephen Gallagher sgallagh at redhat.com
Thu Jan 6 20:19:45 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/06/2011 02:10 PM, Stephen Gallagher wrote:
> On 01/06/2011 06:11 AM, Sumit Bose wrote:
>>>>> 0002: should fix #757. If only the local provider was configured the
>>>>> code did not return to the main loop during execution and the callback
>>>>> of the corresponding tevent request was never called.I think this is a
>>>>> regression from the introduction of the synchronous sysdb interface. To
>>>>> fix it I added a timer event which just calls *_step() again to make
>>>>> sure we always return to the main loop at least once. Of someone knows
>>>>> of a more elegant solution I'm all ears. Btw. the code cries for
>>>>> refactoring.
>>>>>
> 
>> We have a convention we use in other similar cases. Instead of creating
>> a new event, just change the return values from nss_cmd_set*ent_step()
>> to use EOK for "return with immediate post" and to EAGAIN for "return
>> and re-enter mainloop"
> 
>>> ok, I've changed the patch to use this convention. New and renamed
>>> version attached.
> 
> Ack
> 
> 

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0mI+EACgkQeiVVYja6o6PlUgCfcOwI5M1DEh0tBGwuL2OFZF20
WX8AoIE6iD4XV5KqXPiywSQbn6wn9zDh
=dP5T
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list