[SSSD] [INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...

Dmitri Pal dpal at redhat.com
Mon Jan 3 23:12:38 UTC 2011


Please see the attached patches. I tried to split the patches logically
into manageable sets.
Unfortunately I made a minor mistake and I am afraid I will do something
wrong to fix it.
I merged two wrong patches. Fortunately it was three liner with 1 liner
so it is not a big of the deal but I am really scared that I will do
something wrong and loose the work I have done.
So I hope it is Ok to send it as is.

0001--INI-Making-Coverity-happy.patch  <- this is the patch I submitted
earlier that I merged by mistake. I was supposed to merge it with patch
25 but picked the wrong one instead.
Patch 25 addresses the real issue found by Coverity as mentioned in
Stephen's review mail but it did not apply cleanly since it relies on
some code from the patches in the middle. 

0002--INI-Adding-missing-function-declararion.patch  <- this is the
patch that was rejected from the second set sent earlier. Fixed
according to review comment.

0003--BUILD-Allow-trace-per-component.patch <- This patch allows tracing
per component

The following set of patches introduces the merging of sections during
the reading of the file:
0004--INI-New-error-codes-and-messages.patch
0005--INI-New-merge-flags.patch
0006--INI-Add-new-vars-to-parse-structure.patch
0007--INI-Add-save_error-function.patch
0008--INI-Change-parse_error-to-use-save_error.patch
0009--INI-Preparing-for-merging-sections.patch
0010--INI-Enhance-value-processing.patch
0011--INI-Use-section-line-number.patch
0012--INI-Refactor-section-processing.patch
0013--INI-Return-error-in-DETECT-mode.patch
0014--INI-New-test-files-for-section-merge.patch
0015--INI-Test-DETECT-mode-and-use-new-file.patch
0016--INI-Test-for-all-section-merge-modes.patch

Patches related porting of the meta data from old way of doing things to
the new way of doing things:
0017--INI-Separate-close-and-destroy.patch
0018--INI-Function-to-reopen-file.patch
0019--INI-Metadata-collection-is-gone.patch
0020--INI-Check-access-function.patch
0021--INI-Avoid-double-free.patch <- patch related to 17 (missed check)
0022--INI-Function-to-check-for-changes.patch
0023--INI-Tests-for-access-and-changes.patch

0024--INI-Rename-error-print-function.patch <- rename error printing
function for consistency with new interface

0025--INI-Initialize-variables-in-loops.patch <- Coverity issue
addressed. Related to patch 0001.

0026--INI-Exposing-functions.patch <- Make some internal functions reusable
 
There is also patch 27. It is a piece of new functionality. It is a
preview. Please see the comment before reviewing it.
Do I need to split it into multiple patches or it is Ok as is? It is
pretty big but all changes are in one file and logically related.
The UNIT test is missing so I am not claiming it actually works as
expected.

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001--INI-Making-Coverity-happy.patch
Type: text/x-patch
Size: 2216 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002--INI-Adding-missing-function-declararion.patch
Type: text/x-patch
Size: 790 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003--BUILD-Allow-trace-per-component.patch
Type: text/x-patch
Size: 5513 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004--INI-New-error-codes-and-messages.patch
Type: text/x-patch
Size: 4224 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005--INI-New-merge-flags.patch
Type: text/x-patch
Size: 2808 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006--INI-Add-new-vars-to-parse-structure.patch
Type: text/x-patch
Size: 1999 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007--INI-Add-save_error-function.patch
Type: text/x-patch
Size: 1754 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008--INI-Change-parse_error-to-use-save_error.patch
Type: text/x-patch
Size: 2233 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009--INI-Preparing-for-merging-sections.patch
Type: text/x-patch
Size: 6653 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010--INI-Enhance-value-processing.patch
Type: text/x-patch
Size: 10509 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011--INI-Use-section-line-number.patch
Type: text/x-patch
Size: 1099 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012--INI-Refactor-section-processing.patch
Type: text/x-patch
Size: 6301 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013--INI-Return-error-in-DETECT-mode.patch
Type: text/x-patch
Size: 1245 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014--INI-New-test-files-for-section-merge.patch
Type: text/x-patch
Size: 12818 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015--INI-Test-DETECT-mode-and-use-new-file.patch
Type: text/x-patch
Size: 3331 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016--INI-Test-for-all-section-merge-modes.patch
Type: text/x-patch
Size: 7698 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0015.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017--INI-Separate-close-and-destroy.patch
Type: text/x-patch
Size: 5350 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0016.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018--INI-Function-to-reopen-file.patch
Type: text/x-patch
Size: 4133 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0017.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019--INI-Metadata-collection-is-gone.patch
Type: text/x-patch
Size: 8352 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0018.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020--INI-Check-access-function.patch
Type: text/x-patch
Size: 4158 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0021--INI-Avoid-double-free.patch
Type: text/x-patch
Size: 859 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0022--INI-Function-to-check-for-changes.patch
Type: text/x-patch
Size: 2206 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0023--INI-Tests-for-access-and-changes.patch
Type: text/x-patch
Size: 9120 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0022.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0024--INI-Rename-error-print-function.patch
Type: text/x-patch
Size: 4394 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0023.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0025--INI-Initialize-variables-in-loops.patch
Type: text/x-patch
Size: 2913 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0024.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0026--INI-Exposing-functions.patch
Type: text/x-patch
Size: 1859 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0025.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0027--INI-Function-to-merge-two-configurations.patch
Type: text/x-patch
Size: 17249 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110103/8ac44d01/attachment-0026.bin>


More information about the sssd-devel mailing list